search

Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
https://themeshaper.com
GNU General Public License v2.0
882 stars 351 forks source link

Payton: Theme palette reverted after making changes to menus in the Customizer in FSE #5625

Open ariel-maidana opened 2 years ago

ariel-maidana commented 2 years ago

Quick summary

If you change the palette from global styles in an FSE site with the Payton theme, and then you modify a menu from Appearance ---> Customize ---> Menus, the colors in the theme palette are reverted after you save the changes to the menu.

This doesn't happen if you edit the menu with the Site Editor.

Steps to reproduce

  1. Go to Site ---> Editor.
  2. Click on Styles ---> Colors.
  3. Edit the theme palette.
  4. Go to Appearance ---> Customize ---> Menus.
  5. Edit the menu assigned to the Primary Navigation.
  6. Save the changes.
  7. The palette will be reverted.

What you expected to happen

The palette we set from the Global Styles should be kept.

What actually happened

The palette was reverted.

Context

Report: 4823338-zd-woothemes

Simple, Atomic or both?

Atomic

Theme-specific issue?

Payton.

Browser, operating system and other notes

MacOS

Reproducibility

No response

Severity

No response

Available workarounds?

Yes, easy to implement

Workaround details

You can edit the menu with the Site Editor, instead of Appearance ---> Customize ---> Menus.

Robertght commented 2 years ago

Hey @ariel-maidana ! Thank you for reporting this!

I tested this on an AT site, but I was not able to replicate the issue. Was a plugin conflict test run in advance?

Finally, could we test this on your website as well?

ariel-maidana commented 2 years ago

Hey @Robertght !

I took a screencast from my test site:

https://user-images.githubusercontent.com/4965723/156854539-041ccd60-6d98-498e-9311-1c4562b58fcc.mp4

Was a plugin conflict test run in advance?

Didn't run a test, but the only active plugins on my test sites are: akismet, amp, crowdsignal-forms, polldaddy, gutenberg, jetpack, layout-grid, page-optimize, full-site-editing and wpcomsh-loader.

Finally, could we test this on your website as well?

Yes, of course!

Robertght commented 2 years ago

Thank you! That helps a lot!

I noticed Gutenberg wasn't active when I initially tested, but after activating it, I was able to replicate this issue.