search

Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
https://themeshaper.com
GNU General Public License v2.0
901 stars 357 forks source link

Livro: Newsreader font is no longer loaded #5705

Closed markhowellsmead closed 2 years ago

markhowellsmead commented 2 years ago

Steps to replicate

The Newsreader font is still defined in CSS but the font file/s are no longer loaded.

Result

The website typography appears in the standard browser fallback serif font.

Expected

The Newsreader fonts in the assets folder should be loaded by the theme.

jffng commented 2 years ago

Thanks for the report, we just made the switch to load the fonts via theme.json since Gutenberg was upgraded, my guess is this is an artifact of some caching.

Newsreader is loading on the demo site, so I'm going to close this:

Screen Shot 2022-03-18 at 11 44 57 AM
markhowellsmead commented 2 years ago

@jffng Font still not loading even with caching disabled on the site and it's running the latest version of the theme (1.0.9). There is no reference in the source code to the WOFF files. If I look at the documentation for theme.json, there is no reference that the src attribute is supported for fontFamilies.

jffng commented 2 years ago

The Webfonts API was recently added https://github.com/WordPress/gutenberg/pull/37140, and the theme.json documentation needs to be updated accordingly. This feature is not in core yet, are you running the Gutenberg plugin?

markhowellsmead commented 2 years ago

No, I'm using the Theme directly from https://wordpress.org/themes/livro/. The Gutenberg plugin is highly unstable and often breaks functionality, so it's not possible to use it on a production site. I'm guessing that this issue is happening for the 200+ other non-WordPress.com users too, unless they're using the plugin.