search

Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
https://themeshaper.com
GNU General Public License v2.0
888 stars 355 forks source link

Social Menu: Amazon and Goodreads social icons don't work (several themes) #5836

Open druesome opened 2 years ago

druesome commented 2 years ago

Quick summary

When adding links to Amazon or Goodreads to a social menu, they do not display their icons. Instead, we see the default link icon for unsupported sites.

Steps to reproduce

  1. Activate a theme that supports social menus (ie Twenty Seventeen)
  2. Go to Customizer > Menus
  3. Create a new menu and assign it to Social Menu location
  4. Add links to Amazon and Goodreads
  5. Press Save Changes

What you expected to happen

For the social menu to display the icons for Amazon and Goodreads. They are both mentioned as supported icons on our support page:

https://wordpress.com/support/menus/social-links-menu/#supported-icons

What actually happened

They are not displaying their icons but rather the default link icon for unsupported sites.

Context

No response

Browser

No response

Simple/Atomic

No response

Other notes

No response

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

No response

Workaround details

No response

jordesign commented 2 years ago

I've tried testing this and it appears to work ok in Varia themes. But is definitely an issue in:

inaikem commented 2 years ago

Tested and replicated in a number of Varia themes. Switching to a non-Varia theme like TT1 resolved the issue.

Incidentally, switching to a retired premium theme like Ovation showed an Amazon link as expected, but not the Goodreads link.

Transferring to the themes repo.

kathrynwp commented 2 years ago

Re: Twenty Seventeen, I think it's probably to be expected that this bundled (aka default/core) theme doesn't necessarily support the same social icons as the ones mentioned in the support document linked to above. As a bundled theme, it's not necessarily going to follow the same standards as Automattic themes, or themes supporting Jetpack's social menu. For that reason, I'm not going to open a ticket in Core Trac, as this type of enhancement to a 5-year-old core theme isn't going to be a high priority.

That said, there are CSS workarounds that could be used to replace the chain link with another icon in the media library.

I'll leave this ticket open in case someone does have a chance to look at the other themes mentioned and decide whether a fix can be made.