Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
https://themeshaper.com
GNU General Public License v2.0
907 stars 358 forks source link

Zoologist, and others: Title sizes, inconsistent between Simple and Atomic sites #6141

Open manuelrebollo-a11y opened 2 years ago

manuelrebollo-a11y commented 2 years ago

Steps to replicate

Applying the Zoologist theme to a Simple site produces a small, all-caps site title and larger post titles:

simple

Applying the same theme to an Atomic site produces a large site title and smaller post titles:

atomic

In both cases, the Site Title block reports using the H1 style by default. No changes to either site under Editor > Styles.

I reproduced the issue under Google Chrome and Safari, updated versions. Also, the same inconsistency is present in other themes, such as Archeo and Skatepark.

Result

Site title and other headings do not reflect the sizes shown in the theme's Info page when the theme is applied to Atomic sites.

Expected

Both Simple and Atomic sites should have consistent header sizes if using the same theme with its default settings.

devNigel commented 2 years ago

Hi @manRebollo , looks like this bug report is missing some additional required details and it is possible that it was probably missed by bug herders. I have added the missing items.

Please always create bug reports from the button on Bugomattic page.

Robertght commented 2 years ago

📌 HOUSEKEEPING

📌 SCRUBBING

📌 FINDINGS/SCREENSHOTS/VIDEO

📌 ACTIONS

cometgrrl commented 2 years ago

@Robertght Noticed this is filed in Automattic/themes. Is that correct? If it's covered by the themes team, we can move it over to the "other" column of the board. Or, we can add a Themes column if that would be useful for tracking? @vajrasar @inaikem what do you think?

pbking commented 2 years ago

While working on #6123 I encountered just this scenario locally. The Site-Title was the obvious culprit but there may have been other blocks. This seems to have been caused by querying global styles data too early; before all of the blocks have been registered. Those un-registered lose any of the block settings defined in the theme's theme.json file.

I'm not sure why this might be happening on Atomic (and not simple) sites however. Since you noted that this also is happening in Skatepark (which is not a Blockbase child) it leads me to believe that this is a problem introduced elsewhere; outside of the theme.

Robertght commented 2 years ago

I can confirm this happens with Antonia and Russell as well. My guess is that it might also be related to the global styles and how they are defined on atomic, but I cannot confirm this.

My case is in 5494098-zen

@jeffikus @pbking can we prioritize this in the near future?

@cometgrrl sorry for the late reply here and thank you for bringing this up. Having a "Themes" option helps!

github-actions[bot] commented 2 years ago

Support References

This comment is automatically generated. Please do not edit it.

candy02058912 commented 2 years ago

Was trying things around this issue and here are my observations (since I'm not sure what's the cause codewise, but hopefully it could help narrow down the issue a little bit):

Testing was done with the default twentytwentytwo theme (only atomic sites have this issue, simple sites and self-hosted sites don't). As @pbking mentioned, this might be a problem outside of themes.

Steps:

candy02058912 commented 2 years ago

Update: This issue seems to have been fixed when I checked out the test site I was using today with the latest Gutenberg version.

chiape commented 1 year ago

Hey folks! I stumbled on this zen-6183305 and it seems a very similar issue. When the user changes their Headings (H2) size from the Styles it doesn't reflect on their site. Just taking the opportunity to chime in since it's still an open issue! :)

The theme, in this case, is "Archivo", but it's not clear to me if it's a theme or a calypso issue yet! ^^

Thanks!