Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
https://themeshaper.com
GNU General Public License v2.0
900 stars 357 forks source link

Gazette Theme: Contact Form fields use the site's background color #6175

Open ktyfuller604 opened 2 years ago

ktyfuller604 commented 2 years ago

Quick summary

In the Gazette theme, what you select as the Background color in Colors & Backgrounds will apply to form fields as well.

Similar report: https://github.com/Automattic/themes/issues/5397 (this report is for WooCommerce fields)

Steps to reproduce

  1. Activate the Gazette theme
  2. Change the background color to black (for example)
  3. Add a contact form
  4. Apply a background color to the contact form

What you expected to happen

The form fills would take on the same background color as the background color set on the contact form block.

What actually happened

The form fill fields were the same color as the background of the site. And there was no way to change that without CSS.

I also noticed that all of the fill fields in the sidebar when clicking on any block were also black (see the screenshot below).

Context

Customer Report

Their screenshots: 2 Capture

Simple, Atomic or both?

Simple, Atomic

Theme-specific issue?

Gazette

Browser, operating system and other notes

n/a

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

Yes, easy to implement

Workaround details

Provided CSS to resolve the issue.

aisajib commented 2 years ago

πŸ“Œ SCRUBBING

πŸ“Œ FINDINGS/SCREENSHOTS/VIDEO

In the Gazette theme, what you select as the Background color in Colors & Backgrounds will apply to form fields as well.

I'm wondering if this isn't the expected result. I tested using a different theme (Canard) and here's what I see with a black background selected in Colors & Background (site-wide) and no background color selected on the Form block:

Screen Shot 2022-07-10 at 11 02 10 PM

If the form fields didn't take the site background color, it would have looked odd in my opinion.

Here's another form block from the Appleton (FSE) theme:

Screen Shot 2022-07-10 at 11 04 38 PM

I did notice, however, that changing the form block's background color doesn't affect the background of the fields. Here's the Canard theme with the Form block's background set to Red:

Screen Shot 2022-07-10 at 11 06 18 PM

On an FSE theme (Appleton), changing the Form background does change the background of the field as well.

Screen Shot 2022-07-10 at 11 16 17 PM

Also, I could replicate the background color showing up on the block editor, but this only happened on an atomic site. Screenshot:

Screen Shot 2022-07-10 at 11 17 39 PM

Overall, I'm slightly confused about what exactly is the expected result here, and why it's working differently on different themes.

I'm moving this to the themes repo so the theme folks can take a look at it.

πŸ“Œ ACTIONS