Open pbking opened 2 years ago
I looks like when Blockbase was upgraded to v3 (removing the Customizer palette colors) Quadrat had customizer palettes that were converted to Theme Variations.
Cool.
However, there are ALSO Quadrat Theme Variants that have the same names...
black, green, red, white, yellow blue, dark-blue, green, light-blue, light-green, light-pink, yellow
The only one that seems to overlap is RED
The Quadrat Red variation:
The Quadrat-Red variant:
Thus I will rename the "Quadrat-Red varient theme to be "Light Red" variation instead (since it's a "light" version of red, not because the shade of red is lighter). If there are any better ideas I'm open. :)
The TwentyTwentyTwo theme variations are a different animal than the rest. They have different templates (headers that re-arrange which colors go where) and just dropping in the color (or other theme.json values) into a theme variation wouldn't yield exactly the same results. Additionally those theme variants weren't managed in the same way as the others. Thus these have been excluded from this change. If eliminating them is important we'll have to do that as a separate task.
I'm going to re-open this issue to track the remaining steps to retire the effected themes. It was closed when the changes were merged but there are some additional steps to track.
I just did a search for Geologist and Quadrat and it seems that Quadrat-Black is still being used for tests and Geologist-Cream in the 'all-mobile-starter-designs' list.
Does that prevent us from continuing to retire these themes? Can we go ahead and complete the retiring steps for those themes without impacting those two things?
I believe those are the last two blocking items before these themes can (finally) be retired.
The following themes have variants. These should be refactored to instead be Theme Variations so that the Variants can be retired.
Quadrat Geologist
TwentyTwentyTwo (a core theme, the change will be different than Quadrat/Geologist)Videomaker (a premium theme. should this be included?)NOTE: There are currently a few blockers preventing SOME of these themes from being retired. That conversation can be found here: pNEWy-fHZ-p2
To complete this task:
PNEWy-tR-p2