search

Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
https://themeshaper.com
GNU General Public License v2.0
884 stars 351 forks source link

Nucleare: Sidebar text color difference (Customizer vs Published) #671

Open Robertght opened 5 years ago

Robertght commented 5 years ago

Steps to replicate

  1. Using Chrome, Go to Customizer-> Colors & Backgrounds
  2. Click on Paletes-> Manual-> Pick your own color and add this one: #0a5dd0
  3. Check the Preview sidebar text color
  4. Check the Published changes(outside the customizer_ sidebar text color.

Result

Preview: Customize Bognor Regis Womens Institute 2019-03-12 14-14-11

Published: Bognor Regis Womens Institute 2019-03-12 14-14-25

What happened

The Preview shows a lighter variant of grey, whilst the Published version shows a darker one, making it impossible to read.

Expected

To have the same results as in the Preview.

Slack ref: https://a8c.slack.com/archives/C029FM1EH/p1552413203300700

User report: 7359660-hc

alaczek commented 5 years ago

hi @Robertght! Could you include theme name in the ticket title in the future? :)

alaczek commented 5 years ago

Not sure I'm understanding the issue correctly, so please let me know if I'm missing something.

It looks like the customer is on a plan that doesn't include advanced customization. This means that while they can change background color, the color annotations needed to make the text legible are not being loaded on the front end. They are being loaded in the Customizer as a form of a preview, hence the difference you're describing. I know this is not intuitive and confusing, but not much that we can do here from the theme perspective. To verify please try adding a dark background on a site with premium plan or higher - in this case the text and link color in the sidebar should match both on the front end and in the customizer.

Robertght commented 5 years ago

Howdy @alaczek ! Sorry for the missing info on the theme name!

The issue is present on my Premium plan as well and on their Personal one so I think it's not related to that, but to the logic of the colors which are being preview&outputed. Would reporting this to Trac help better? It's probably just an edge case but it's best if we can monitor this somehow.

Thanks! :)

alaczek commented 5 years ago

This is the right place to report, it's just that I cannot replicate this on a site with premium plan. Could you share which colors exactly did you try?

Robertght commented 5 years ago

Apologies for the delay! I tried to re-replicate this and I got inconsistent results so I thought I'd probably messed something up. I did end up replicating this on a free plan site but not on a Premium plan anymore - so weird. Was there an adjustment for this in the last days?

Here's the color I used again: #0969ef (that's on the user's site atm)

Still, I think this is quite a weird behavior because it should still show up the correct result in the preview regardless of the plan. Otherwise we'll end up with a lot of frustrated users with this message "I expected to see the same thing when I published".

kristarella commented 5 years ago

Can confirm this is an issue on free and Personal sites:

  1. activate Nucleare
  2. change background color to #0969ef
  3. see that preview has white text on dark blue background
  4. Publish
  5. view site, and sidebar text is grey, almost unreadable

I found most of a workaround by choosing the dark background palette and then making the background #0969ef. However, some text is still too dark, like the search bar https://cld.wthms.co/vSwYdB