Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
https://themeshaper.com
GNU General Public License v2.0
900 stars 357 forks source link

Gazette: Post Carousel block content picked up by entry-header on posts, archives #7126

Open jp-imagines opened 1 year ago

jp-imagines commented 1 year ago

Quick summary

Slack with more context: p1685736711812349-slack-C03TY6J1A

I was completely unable to replicate this, but it definitely feels like a bug with this theme. Switching themes fixed the issue.

On this user's site, there are horizontal lines that appear on top of all featured images. The lines correspond to top borders on a series of duplicate .entry-meta elements: Markup on 2023-06-02 at 16:13:48

Specifically from this CSS:

.entry-meta+.entry-meta {
    border-top: 2px solid #eee;
    margin-top: 9px;
    padding-top: 14px
}

Steps to reproduce

update 2023-06-07

  1. Activate Gazette theme on simple site
  2. Publish a post with a featured image & View
  3. Return to the Post and add a Post Carousel block
  4. Update and view post again

see triage notes below for more details

What you expected to happen

There shouldn't be duplicate .entry-meta elements, and no horizontal lines.

What actually happened

Random horizontal lines.

Impact

One

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

Simple

Logs or notes

User reported in 6361628-zd-woothemes

github-actions[bot] commented 1 year ago

Support References

This comment is automatically generated. Please do not edit it.

worldomonation commented 1 year ago

πŸ“Œ REPRODUCTION RESULTS

Tested on Simple – not reproducible
Tested on Atomic – not reproducible
Replicable outside of Dotcom – n/a

πŸ“Œ FINDINGS/SCREENSHOTS/VIDEO

Simple

image

AT

image

πŸ“Œ ACTIONS

cuemarie commented 1 year ago

πŸ“Œ SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

πŸ“Œ FINDINGS/SCREENSHOTS/VIDEO

Steps to replicate

  1. Activate Gazette theme on simple site
  2. Publish a post with a featured image & View
  3. Return to the Post and add a Post Carousel block
  4. Update and view post again

The entry-header picks up content from the wp-block-newspack-blocks-carousel block. It happens whether the post carousel is added to the post itself or to a widget area; however the widget area will impact more parts of the site.

Screenshots/Recordings

Added the post carousel to the footer in this example

https://github.com/Automattic/themes/assets/27249804/db34ba37-4cf8-42c0-882c-3dc9d3cbb271

Markup on 2023-06-07 at 12:59:53

Tested switching to other themes that support Custom Headers/Featured Image Headers (Karuna, Lyretail, Resonar, and Twenty Seventeen), and couldn't repro anywhere other than Gazette.

Update

If you enable Show Category in the Article Meta Settings, this seems to be where that line & specific css comes from:

.entry-meta + .entry-meta {
  border-top: 2px solid #eee;
  margin-top: 9px;
  padding-top: 14px;
}
screenshot

Markup on 2023-06-07 at 13:16:58

πŸ“Œ ACTIONS