Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
https://themeshaper.com
GNU General Public License v2.0
882 stars 351 forks source link

Reverie: 'Fall' style variation - menu contrast #7258

Open sophiegyo opened 1 year ago

sophiegyo commented 1 year ago

Quick summary

The 'Fall' style variation of Reverie has the navigation menu with pink text on the white image backgrounds, making it extremely hard to see.

Steps to reproduce

  1. Start at https://wordpress.com/theme/reverie/
  2. Select the 'Fall' variation and open the demo site with it active
  3. Open the nav menu at the bottom
  4. Try to read the menu items

What you expected to happen

The menu items would have a better contrast colour to make them easy to read.

What actually happened

They are not easy to read.

image

Looks like it's due to the nav block being set to use the secondary color of the palette:

image

It happens on Atomic too (with bonus evidence of the current issue with nav blocks vs content in other cover blocks):

image

Browser

Google Chrome/Chromium, Mozilla Firefox, Microsoft Edge, Apple Safari

Context

https://wordpress.com/forums/topic/bug-in-a-reviere-theme-pallete/?view=all

Platform (Simple, Atomic, or both?)

No response

Other notes

No response

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

Yes, easy to implement

Workaround details

I tested on my AT site, while changing the text color of of the nav block (NOT the overlay text color, that has no effect) does work, it also has the effect of changing the menu icon color to the same darker contrast, which makes it harder to see.

Choosing an overlay text color has no effect: Screenshot on 2023-07-24 at 09-52-47

Apparently it's because the menu items are !important inheriting the color:

image

Easiest workaround is to set the nav block text color to something which contrasts well with both light and dark, like this:

image

Result:

image
cuemarie commented 1 year ago

📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

📌 FINDINGS/SCREENSHOTS/VIDEO

Screenshots/Recordings

Markup on 2023-07-24 at 13:53:12

📌 ACTIONS