search

Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
https://themeshaper.com
GNU General Public License v2.0
897 stars 356 forks source link

Low Fi: Remove the space in the theme display name #7730

Closed iamtakashi closed 6 months ago

iamtakashi commented 6 months ago

Changes proposed in this Pull Request:

This removes the space in the theme display name, but there is no change in the slug and the text domain.

The display name was Low Fi, and Dotorg wants the theme slug and the text domain to be low-fi with that name. Since naming changes in an already launched theme is a nightmare, I'm changing the display name to LowFi (removing the space between Low and Fi) so the current slug and text domain, lowfi, makes better sense.

iamtakashi commented 6 months ago

Thanks, @mikachan, for the quick review. Merging is a click of a button, but should I worry about deploying this change to dotcom, too? Can't that be automated?

mikachan commented 6 months ago

I didn't merge this immediately as it was late where I was and I didn't want to deploy in the evening. I'll deploy this now.

We're looking into how we can automate the deploy to dotcom. I wonder if this sits well with the Theme Launcher on dotcom - I've opened an issue for it here: https://github.com/Automattic/mc-theme-launcher/issues/2.