Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
https://themeshaper.com
GNU General Public License v2.0
898 stars 356 forks source link

Multiple Themes: Improve the Table Block Styles Preview #7752

Open kspilarski opened 11 months ago

kspilarski commented 11 months ago

What

The preview of the table block Stripes Style does not show the alternating gray colors of the rows.

Why

The two table styles Default and Stripes both show the preview of the table with a gray background. When Stripes style is clicked, the preview does not show the alternating gray colors of the rows.

How

In the Table block Styles preview, remove the gray background to show the alternating row colors in the Stripes style.

In Account Settings, changing the Dashboard color scheme does not have any effect on the Table Styles preview.

Default:

table - default

Stripes:

table - stripes
cat-og commented 10 months ago

📌 REPRODUCTION RESULTS

📌 FINDINGS/SCREENSHOTS/VIDEO

However, I did notice that the default color options on my simple site, using the Twenty Twenty-Four made that contrast very difficult to see:

Image

📌 ACTIONS

📌 Message to Author @kspilarski which theme were you using when you encountered this issue?

kspilarski commented 9 months ago

Epi and Sten themes (where gray is the main color), Stripes doesn't show the alternating colors:

Screenshot 2024-01-02 at 14 41 45

I tested this also using another theme like Organizer, and Stripes show the alternating colors:

Screenshot 2024-01-02 at 14 38 37

Dara theme also show Stripes with alternating colors, but subtle and not so visible:

Screenshot 2024-01-02 at 14 40 13
liviopv commented 6 months ago

@kspilarski Thanks for the additional context, sorry for the delayed reply.

It sounds more like a bug than a feature request, and, there is an existing issue here https://github.com/WordPress/gutenberg/issues/60091. Would you be open to restructuring the original report based on that and listing the themes where it doesn't work?

I left a comment here https://github.com/WordPress/gutenberg/issues/60091#issuecomment-2023016635 to add context based on what you reported, but please jump to share more as needed, just remember it's a public community-led repository.

Also, there is a workaround to ensure contrast in the Stripe styles:

  1. Appearance > Editor > Styles
  2. Blocks > Table Block
  3. Style Variations > Stripes
  4. Adjust the background color
rickmgithub commented 6 months ago

Re-pinged OP directly to check.

mrfoxtalbot commented 6 months ago

I have followed up with the conversation in https://github.com/WordPress/gutenberg/issues/60091#issuecomment-2023016635

We used to have a label for "Needs upstream Fix" but I cannot find it. I think it would make sense to continue using that label.

kspilarski commented 6 months ago

It sounds more like a bug than a feature request, and, there is an existing issue here https://github.com/WordPress/gutenberg/issues/60091. Would you be open to restructuring the original report based on that and listing the themes where it doesn't work?

mrfoxtalbot commented 6 months ago

As per this comment @t-hamano this issue seems to be theme-specific. I will transfer this to the themes repo.