Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
https://themeshaper.com
GNU General Public License v2.0
890 stars 354 forks source link

Not possible to change page/post templates when `Peirao` theme is active #7766

Closed ClassicRKR27 closed 5 months ago

ClassicRKR27 commented 5 months ago

Quick summary

User should be able to switch the templates that their pages/posts are using, but in the course of this conversation I found that this is a bug with this theme: 8087247-zd-a8c

Steps to reproduce

  1. Activate the Peirao theme on any WordPress.com site
  2. Try to edit either a page or post by changing the template - you'll see that there is no option to switch the template: ygaqq1.png

What you expected to happen

Users should be able to switch their page/post templates

What actually happened

It is not possible to switch the templates

Browser

No response

Platform (Simple, Atomic, or both?)

Simple, Atomic

Other notes

No response

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

None

Workaround details

No response

github-actions[bot] commented 5 months ago

Support References

This comment is automatically generated. Please do not edit it.

liviopv commented 5 months ago

📌 REPRODUCTION RESULTS

📌 FINDINGS/SCREENSHOTS/VIDEO Simple site https://github.com/Automattic/themes/assets/14153300/04d8f588-ffae-4b78-87cd-c96b996466d0

Same as the above on Atomic

📌 ACTIONS

📌 Message to Author @ClassicRKR27 that's the expected behavior, unless I'm missing some context from the interaction.

As you can see, once I add a custom template, the "Swap Template" option shows up for both Post and Pages.

Looking at the user's site, they don't have any custom template that can be applied to any post/page, so it's correct for them to only see "Edit Template" and "Create New Template".

They only have a custom template for a specific page, "Instruction"

ClassicRKR27 commented 5 months ago

@liviopv are we sure this is by design? Because the Swap Template option appears in other themes with no custom templates: SPahWM.png

The above is with the Cakely theme, and for the Peirao theme it's still not possible to swap templates even once a custom template has been created.

liviopv commented 5 months ago

@ClassicRKR27 Cakely has two custom Page Templates bundled in the theme, unlike Peirao:

CleanShot 2024-04-30 at 16 23 20@2x

ClassicRKR27 commented 5 months ago

@liviopv in that case, why is the option to swap templates not appearing for this user when they do have a custom template? BfDZZM.png

If this is expected behavior, then it's very confusing - it's not clear why some themes come with custom templates and some don't, there doesn't seem to be any indication of why they're not able to switch templates when there isn't a custom template created.

liviopv commented 5 months ago

@ClassicRKR27 That template is for a specific page, Instruction, as mentioned at the end of my first message.

If this is expected behavior, then it's very confusing - it's not clear why some themes come with custom templates and some don't, there doesn't seem to be any indication of why they're not able to switch templates when there isn't a custom template created.

You're welcome to share that feedback on https://github.com/WordPress/gutenberg/issues just make sure to avoid sharing any a8c-related information.

That said, the behavior makes sense to me, as "Swap Template" only shows up when there's a template to swap to:

In cases like Peirao where there's no template to "Swap" to, where would the "Swap Template" link to?