search

Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
https://themeshaper.com
GNU General Public License v2.0
890 stars 354 forks source link

Feelin'Good: Prepare for the submission. #7770

Closed iamtakashi closed 5 months ago

iamtakashi commented 5 months ago

Changes proposed in this Pull Request:

github-actions[bot] commented 5 months ago

Preview changes

I've detected changes to the following themes in this PR: Feelin'Good.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR. ⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

iamtakashi commented 5 months ago

@mikachan Thanks for reviewing and merging this. This doesn't seem to be deployed to WP.com, so there are no edits on the version number and readme.txt. Do I need to do anything else?

iamtakashi commented 5 months ago

Do I need to do anything else?

Maybe, did you expect me to run npm run deploy:version-bump? I remember we discussed that the script for bumping theme versions will be separated from deploying changes to Dotcom.

mikachan commented 5 months ago

We need to run a deploy but there are multiple theme changes queued up, so I'm currently seeing if they can all be deployed at once. It's looking fine I think so this should be deployed soon.

iamtakashi commented 5 months ago

OK, thank you for clarifying!

mikachan commented 5 months ago

This has been deployed now!

iamtakashi commented 5 months ago

Hmm, but no update has been made to the readme.txt, and the version number hasn't increased. Why do you think that is? The deploy process should take care of it, no?

mikachan commented 5 months ago

Yes, the deploy process takes care of that. The readme.txt was updated here with a version bump and changelog update: https://github.com/Automattic/themes/commit/738fb07fd914c0d19c633c02f34d5481dfff228b#diff-c0a3fdf16f8cbe4c3fce1dc791968145987dd6dab5e10a8ed46643dc6916215e

iamtakashi commented 5 months ago

Oh!? I see them updated now. That's good, I wondered why I couldn't see them when I posted the last comment. Have you experienced something like this?

mikachan commented 5 months ago

Have you experienced something like this?

Not specifically like this, but I'm wondering if you checked the files before the version bump was pushed maybe?

iamtakashi commented 5 months ago

Okay, I'm not sure what happened. Anyway, thank you!