Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
https://themeshaper.com
GNU General Public License v2.0
847 stars 342 forks source link

Colinear: Customizer colors affect post/page editor element styles on Atomic sites #7818

Open jp-imagines opened 1 month ago

jp-imagines commented 1 month ago

Quick summary

If you change any color in the Customizer (Appearance > Customize > Colors & Backgrounds), some new CSS takes effect in the editor which overrides the styles used for editor elements (including hover styles), which can make them difficult or impossible to read. This affects tabs (e.g. "Page/Post," "Block," "List View," "Outline," "Patterns," "Media") and settings headings (e.g. "Summary", "Styles," "Advanced").

Steps to reproduce

  1. Activate the Colinear theme.
  2. Open a post or page in the editor. Check that the various tabs and headings in the side panels (insert block, list view, settings, Jetpack settings, kebab menu) are all legible as black text on white backgrounds with appropriate hover effects.
  3. Navigate to Appearance > Customize > Colors & Backgrounds. Change any of the four colors and save changes.
  4. Navigate back to the post/page editor (or refresh the page). Compare the various editor elements' styles with what was seen in step 2.

What you expected to happen

Theme color styles should not affect editor elements.

What actually happened

The theme color styles add some additional inline CSS (custom-colors-editor-css-inline-css), which is loaded after the editor style CSS file, and therefore takes precedence. In many cases, this causes editor elements to become difficult or impossible to read when not hovered over (or when being hovered over), depending on the colors set.

Screenshot below is an example with only the "Links" color changed to a light pink. ("Block" tab in the right settings sidebar is being hovered over.)

PYk5sT.png

Browser

No response

Context

Initial report in 8219316-zd-a8c. Similar to https://github.com/Automattic/themes/issues/6955 (Illustratr theme).

Platform (Simple, Atomic, or both?)

Atomic

Other notes

Only tested on Atomic so far.

Initial customer reported that this affected the help center window as well, though I haven't been able to replicate that yet. Asking them for more information or screenshots – if this affects the help center, I'd imagine that will affect the priority of this issue.

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

No but the platform is still usable

Workaround details

No response

github-actions[bot] commented 1 month ago

Support References

This comment is automatically generated. Please do not edit it.

liviopv commented 1 month ago

📌 REPRODUCTION RESULTS

📌 FINDINGS/SCREENSHOTS/VIDEO

Atomic https://github.com/Automattic/themes/assets/14153300/e487caaa-c2ac-4360-ba37-eabb154e486f

📌 ACTIONS