search

Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
https://themeshaper.com
GNU General Public License v2.0
844 stars 342 forks source link

Fixed Blockbase children style variations #7859

Closed rcrdortiz closed 2 weeks ago

rcrdortiz commented 2 weeks ago

Changes proposed in this Pull Request:

Excluded some style variations that are not compatible with some Blockbase child themes. Now we can have Style Variations applied without needing to exclude the full list of style variations.

Related issue(s):

github-actions[bot] commented 2 weeks ago

Preview changes

I've detected changes to the following themes in this PR: Russell, Farrow, Otis, Meraki, Artly, Attar, Dorna, Appleton, Heiwa, Marl, Erma.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR. ⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

⚠️ Note: Child themes are dependent on their parent themes. You will have to install the parent theme as well for the preview to work correctly.

rcrdortiz commented 2 weeks ago

I think Kerr's charcoal style variation needs disabling too. It's mentioned on Automattic/wp-calypso#78559 and the footer looks broken to me

Screenshot 2024-06-17 at 09 55 09

Kerr doesn't seem to be in the themes repo.

dsas commented 2 weeks ago

Kerr doesn't seem to be in the themes repo.

oops, didn't notice that it's a premium theme.

mmtr commented 2 weeks ago

Can we also fix the themes with issues noted in https://github.com/Automattic/themes/pull/6996#issuecomment-1503295866?

Appleton (Charcoal: site title too dark, Ruby wine: Same as Default) Dorna (Ruby wine: Same as Default) Farrow (Charcoal: text too dark, Ruby wine: Same as Default) Heiwa (Ruby wine: Same as Default) Meraki (Ruby wine: Same as Default) Russell (Charcoal: low contrast text) Zoologist (White: Same as Default)

rcrdortiz commented 2 weeks ago

Can we also fix the themes with issues noted in #6996 (comment)?

Appleton (Charcoal: site title too dark, Ruby wine: Same as Default) Dorna (Ruby wine: Same as Default) Farrow (Charcoal: text too dark, Ruby wine: Same as Default) Heiwa (Ruby wine: Same as Default) Meraki (Ruby wine: Same as Default) Russell (Charcoal: low contrast text) Zoologist (White: Same as Default)

Sure, I just added it to the list of related issues.

Fixing Zoologist is OOS (the problem isn't a side effect of propagating base theme style variations), it doesn't extend a base theme. The White variation is defined inside the Zoologist theme folder.