Maverick: add theme

[henriqueiamarino]

This is a theme in homage to George Lois, visionary American Art Director and author. We will all miss your big ideas. Rest in Peace, George. Demo site

[github-actions[bot]]

Preview changes

I've detected changes to the following themes in this PR: Maverick.

You can preview these changes by following the links below:

• Preview changes for Maverick

I will update this comment with the latest preview links as you push more changes to this PR. ⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

[jasmussen]

Meta note, due to a crash, I lost a big review I had written here 😩, as a result, the second version that I'm writing below here might be shorter. Sorry about that.

General visual observations

Looks good. If you can include demo sites, that might be good, this one can feel a bit bare with just the default WordPress content. But even looking at the screenshot makes it clear what the expression is that this theme is going for:

And that's a good look.

The search block might benefit from a different treatment without borders:

The typography looks like it can be bold, but without some sample content, it's hard to review.

Maybe the site title can have the same allcaps treatment in header and footer?

Style variations

The light style variation looks good too!

I mentioned in another review that coming to Gutenberg are separate color and typography variations. Although you don't have to use those, it's a reminder that style variations can be more than just color changes. They can be font, spacing changes too.

File and readme reviews

I noticed in the style.scss file that there are some local overrides. I appreciate for each of those that you include a link to a GB issue so eventually we can minimize this.

Summary

Overall looks good. I'd love to give it another look in case you have some demo content handy, and in general (future themes, if not this one), it would be good to look at how to upgrade the style variations a bit, at least mix up the typography in addition to the colors.

Thanks for your work!

[henriqueiamarino]

Thanks, @jasmussen, I'll address all your observations individually:

• This is one of those examples of old, old material that has been waiting for years. This is why I don't have demo sites for it. But I'll recreate one to guide your review — I understand that it is a must. And its here;
• On the style variations I get it. But this has changed quite lately, and I don't have practical time to go back and iterate on 40 themes (or more) designed before that. Anyway, I am aware of that, and I have been practicing on my current projects;
• I'm sorry, but I have no idea what local overrides are or how to fix them. They were probably present in the theme I downloaded and updated.

[henriqueiamarino]

And @jasmussen, I agree with all your observations on the Summary, but I don't have time to do so now. I am creating numerous PRs, submitting and editing old issues that keep returning, and I feel the massive need to create new designs. Because that is what people expect from me. It is what I feel people care about, at least from the feedback I receive.

[jasmussen]

Thanks for sharing the demo content. It looks great.

The feedback I'm sharing here is not a blocker for this PR, feel free to move forward. These are mainly observations for new future themes to think about. Or, to tinker with if a chance presents itself to revisit this PR. So you can run with this!

[henriqueiamarino]

@jasmussen, I created a new style variation by inverting the color choices and the typefaces. I also fixed some minor details here and there. Unfortunately, now I have these conflicts and must figure out how to deal with them.

That said, this version is the final one; I'll discard this and create a new PR with no conflicts.

[jasmussen]

Sounds good. Is this PR still valid to review? Or should I review a different one? In any case you can just ping me on whatever PR I shoul review next, otherwise I'll just continue with the list.

[henriqueiamarino]

You can continue with the list. This will be a problematic one. Following Takashi's recommendations, I accidentally merged it when I updated it last time. I have to learn how not to do it. Anyway, I just discovered there's a Maverick theme already in Dotorg, which is not present here where we check. I'll have to rename it and start over this process.

After that, I will ask somebody to help me delete it from the trunk.

[jasmussen]

Sounds good, you can just ping me on any new PR when you're ready!