Closed henriqueiamarino closed 1 week ago
I've detected changes to the following themes in this PR: Russell, Sunderland, Farrow, Loïc, Otis, Meraki, Vitrum, Artly, Hall, Attar, Dorna, Appleton, Heiwa, LeanCV, Marl, Erma.
You can preview these changes by following the links below:
I will update this comment with the latest preview links as you push more changes to this PR. ⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.
⚠️ Note: Child themes are dependent on their parent themes. You will have to install the parent theme as well for the preview to work correctly.
Theme looks good! I noticed a scroll jump for the 100vh sticky image:
But this appears only when the adminbar is present. So that's okay, you the sticky is actually a good solution to this.
A couple of visual bits of feedback. The block gap in this stack looks a little tight:
It's not quite big enough to look intentional, and bumping it just a bit would help. The spacing feedback applies to some of the rest of the page too:
That may be a personal opinion, but just bumping the gaps a little bit might aid legibility. Here's a quick test:
Not strong opinions, let me know if it resonates.
Templates look good. I think across all the theme work, it might be good to do a separate exercise to improve our "no search results found" text. While it can be different from theme to theme, in most cases IMO it can be the same. And these two read a little flowery to me:
Something simpler like "No results found." and "You can try a search:" might be better for both cases. I don't think you necessarily have to address that for this theme, but it's something to generally consider across themes. CC: @beafialho.
Style variations look good. Blue is a good professional default, but the red wine and forest green look great too. Can we find a different name than vampirella?
Vampirella is a trademark! 😅
In a quick code review, I found this lovely picture:
Is that used anywhere? Should it be? I assume the featured person is generated using Midjourney. Same feedback as for "Outnow" for the readme, would be good to change
All images used in the templates were generated with AI using Midjourney.
to
Generated with AI on Midjourney, released under the CC0 license
So in summary, looks good, nice CV theme. Let's get the style variation renamed, the README updated, check if the mary shelley picture needs to be there, and consider whether to do any spacing changes or not, and then this one is good to go. Nice work!
Thanks, @jasmussen. The demo site is live here. I conducted the following changes:
@jasmussen I closed this PR as I can't revert a commit. I created a new one: #7893
LeanCV is a blog theme that echoes the structure of a professional profile with original visuals and interesting navigation. It's suitable for the general public to display information, experiences, and education. And it's super easy to customize.