search

Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
https://themeshaper.com
GNU General Public License v2.0
887 stars 355 forks source link

Moviescript: add theme #7878

Closed henriqueiamarino closed 4 weeks ago

henriqueiamarino commented 3 months ago

Moviescript is a simple blog theme that perfectly suits writers or the general public who want their sites to be formatted as movie scripts. Demo site

screenshot

github-actions[bot] commented 3 months ago

Preview changes

I've detected changes to the following themes in this PR: Moviescript.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR. ⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

MaggieCabrera commented 1 month ago

This theme has a hidden pattern called header-rate that doesn't seem to be used anywhere, can you confirm if it needs deleting, @henriqueiamarino ?

henriqueiamarino commented 1 month ago

Thanks for your review, @MaggieCabrera. Sometimes, I add a pattern that some users might use, but I don't use it in my take on the theme. I never really knew if that was okay or not. If it's not a good practice, you can delete it; no problem.

I am afraid I have no control over the site title as an H1. As I design in the Editor, that is how the site title is available to me; I have other current choices. Also, I can add a title for the Page template; it's no problem. I can also make post titles H1 instead of H2 for the Index. Would that be enough? Working on it.

MaggieCabrera commented 1 month ago

Thanks for your review, @MaggieCabrera. Sometimes, I add a pattern that some users might use, but I don't use it in my take on the theme. I never really knew if that was okay or not. If it's not a good practice, you can delete it; no problem.

It's ok to have but since it has the hidden attribute, it won't show anywhere in the UI for users! I will change that to make it available