Assembler: Update headings color from theme-1 to theme-4 in section styles

Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.

https://themeshaper.com

GNU General Public License v2.0

844 stars 342 forks source link

Assembler: Update headings color from theme-1 to theme-4 in section styles #7897

Closed miksansegundo closed 1 week ago

miksansegundo commented 1 week ago

Changes proposed in this Pull Request:

Update headings color from theme-1 to theme-4 in section-2 and section-3

Related issue(s):

BEFORE	AFTER

github-actions[bot] commented 1 week ago

Preview changes

I've detected changes to the following themes in this PR: Assembler.

You can preview these changes by following the links below:

Preview changes for Assembler

I will update this comment with the latest preview links as you push more changes to this PR. ⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

miksansegundo commented 1 week ago

I'm closing this because section styles 2 and 3 have a dark background, which is why they use white headings.

I'm investigating a bug in the Assembler preview that loads all the styles for all sections, and the styles for section-3 end up overwriting the rest.

Dotcom patterns should use the default section styles as they do in the editor preview, which uses theme-5 preset color for headings.