Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
https://themeshaper.com
GNU General Public License v2.0
907 stars 358 forks source link

Separator block(dots) doesn't render anymore #7978

Open Robertght opened 4 months ago

Robertght commented 4 months ago

Quick summary

In short, the block doesn't render the dots style on Classic themes anymore.

Steps to reproduce

  1. Activate a theme like Canard, Dara or TwentyTwenty.
  2. Create a new page or post
  3. Add a Separator block(dots)
  4. check the results

What you expected to happen

To see the separator block render.

What actually happened

Nothing displayed, yet the markup is there.

Impact

Some (< 50%)

Available workarounds?

YES - see https://github.com/Automattic/themes/issues/7978#issuecomment-2303873208

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

Tested on Simple and Atomic.

Themes where it didn't show up: Canard Dara TwentyTwenty

Themes where it did show up: TwentyTwenty-Four

Case: 8539373-zen

Latest status

github-actions[bot] commented 4 months ago

Support References

This comment is automatically generated. Please do not edit it.

mrfoxtalbot commented 4 months ago

I can replicate this on Twenty Twenty and Canard

Screenshot 2024-07-30 at 09 39 07

Notably, the Separator block (dots) does not show in the editor either.

Screenshot 2024-07-30 at 09 39 56

Turns out I can replicate this in core but only with Twenty Twenty (I opened a track issue for it here https://core.trac.wordpress.org/ticket/61787)

If I tested other themes (Canard and Dara) and the Separator (dots) block DOES show on those themes in self-hosted:

Screenshot 2024-07-30 at 09 46 45 Screenshot 2024-07-30 at 09 46 23

dsas commented 4 months ago

I can reproduce in dara when self-hosted, in both the editor and the front-end. I've opened https://github.com/Automattic/themes/pull/7979 to address it.

dsas commented 4 months ago

Same for Canard, I've opened https://github.com/Automattic/themes/pull/7980 to address

mrfoxtalbot commented 3 months ago

I see this has been fixed. Thank you! Screenshot 2024-08-20 at 18 35 08

dsas commented 3 months ago

@mrfoxtalbot that's the normal separator not the dotted separator. The dotted separator still looks broken to me, and checking the upstream bug there's been no shift for a while.

Editor Site
Screenshot 2024-08-20 at 17 45 45 Screenshot 2024-08-20 at 17 45 59
mrfoxtalbot commented 3 months ago

You're right @dsas, sorry. I got thrown off when I noticed that https://github.com/Automattic/themes/pull/7980 had been merged. Thank you for reopening the issue.

miksansegundo commented 3 months ago

A workaround is adding the following Additional CSS:

.wp-block-separator.is-style-dots::before {
    color: currentColor;
    content: "···";
    font-family: serif;
    font-size: 1.5em;
    letter-spacing: 2em;
    padding-left: 2em;
}

Image

Test site: https://testclassicatomicmiguel.wpcomstaging.com/separators-test/

devNigel commented 3 months ago

Another report: 8639478-zd-a8c

I shared the workaround with the user.

dsas commented 1 month ago

The upstream fix for GB / TT0 got retargeted from 6.7 to a non-specific future release. It's not clear to me how much agreement there is on the best way to fix it.