Remove fixed font-size from post title block on blockbase themes

[renatho]

Changes proposed in this Pull Request:

If we decide to go with this approach (see this discussion in the issue), it removes the fixed font-size from post title block on blockbase themes.

Related issue(s):

https://github.com/Automattic/themes/issues/8046

Screenshots

With the screenshots, I also described if it was needed to change the child theme and the default tag of the post title in the page template.

Blockbase

• Default heading tag: h2.

I took the screenshot from the "All Archives" template only for the Blockbase theme to save time.

Before

After

Ames

• Default heading tag: h2.

Before

After

Antonia

• Default heading tag: h2.

Before

After

Appleton

• Default heading tag: h2.

Before

After

Arbustus

• Default heading tag: h2.
• Also needed a change in the child theme.json.

Before

After

Attar

• Default heading tag: h2.

Before

After

Barnett

• Default heading tag: h2.

Before

After

Bennett

• Default heading tag: h2.

Before

After

Blank Canvas

• Default heading tag: h2.

Before

After

Calvin

• Default heading tag: h2.

Before

After

Dorna

• Default heading tag: h2.

Before

After

Farrow

• Default heading tag: h2.

Before

After

Geologist

• Default heading tag: h1.
• Also needed a change in the child theme.json.

Before

After

Hari

• Default heading tag: h2.

Before

After

Heiwa

• Default heading tag: h2.

Before

After

Jackson

• Default heading tag: h2.

Before

After

Kingsley

• Default heading tag: h2.

Before

After

Marl

• Default heading tag: h2.

Before

After

Mayland (Blocks)

• Default heading tag: h1.
• Also needed a change in the child theme.json.

Before

After

Meraki

• Default heading tag: h2.
• Also needed a change in the child theme.json.

Before

After

Quadrat

• Default heading tag: h1.
• Also needed a change in the child theme.json.

Before

After

Russell

• Default heading tag: h2.
• Also needed a change in the child theme.json.

Before

After

Seedlet (Blocks)

• Default heading tag: h1.
• Also needed a change in the child theme.json.

Before

After

Winkel

• Default heading tag: h2.

Before

After

Zoologist

• Default heading tag: h1.
• Also needed a change in the child theme.json.

Before

After

[github-actions[bot]]

Preview changes

I've detected changes to the following themes in this PR: Arbutus, Blockbase, Geologist, Mayland (Blocks), Meraki, Quadrat, Russell, Seedlet (Blocks), Zoologist. You can preview these changes by following the links below:

• Preview changes for Arbutus (child of blockbase)
• Preview changes for Blockbase
• Preview changes for Geologist (child of blockbase)
• Preview changes for Mayland (Blocks) (child of blockbase)
• Preview changes for Meraki (child of blockbase)
• Preview changes for Quadrat (child of blockbase)
• Preview changes for Russell (child of blockbase)
• Preview changes for Seedlet (Blocks) (child of blockbase)
• Preview changes for Zoologist (child of blockbase)

I will update this comment with the latest preview links as you push more changes to this PR. ⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

⚠️ Note: Child themes are dependent on their parent themes. You will have to install the parent theme as well for the preview to work correctly.

[github-actions[bot]]

Theme-Check results

---

arbutus: There are required changes on the theme ❌.

❎ REQUIRED

• Found a reference to unsplash.com. Assets from this website does not use a license that is compatible with GPL. View license (opens in a new window).
• This theme text domain does not match the theme's slug. The text domain used: blockbase, ) This theme's correct slug and text-domain is arbutus.

💡 RECOMMENDED (2)

- No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes. - Possible variable $header_pattern found in translation function in inc/block-patterns.php. Translation function calls must not contain PHP variables, use placeholders instead. See Internationalization Guidelines (Opens in a new window). Line 39: $header_patterns = array(Line 48: foreach ( $header_patterns as $header_pattern ) {Line 50: 'blockbase/header-' . $header_pattern,Line 52: 'title' => __( 'Blockbase Header (' . $header_pattern . ')', 'blockbase' ),Line 55: 'content' => file_get_contents (get_theme_file_path( '/parts/header-' . $header_pattern . '.html' )),

⚠️ WARNING (4)

- screenshot.png is 555.6 KB in size. Large file sizes have a negative impact on website performance and loading time. Compress images before using them. - Found a translation function that has an incorrect number of arguments in the file inc/block-patterns.php. Function __, with the arguments 'Blockbase Header (', ), 'blockbase'. Line 52: 'title' => __( 'Blockbase Header (' . $header_pattern . ')', 'blockbase' ), - Found a translation function that is missing a text-domain in the file inc/customizer/wp-customize-fonts.php. Function __, with the arguments 'https://wordpress.com/support/custom-fonts/'. Line 13: __( 'https://wordpress.com/support/custom-fonts/' ) - More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are blockbase, ).

ℹ️ INFO (1)

- Found wrong tag, remove auto-loading-homepage from your style.css header.

---

blockbase: No changes required ✅.

💡 RECOMMENDED (2)

- No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes. - Possible variable $header_pattern found in translation function in inc/block-patterns.php. Translation function calls must not contain PHP variables, use placeholders instead. See Internationalization Guidelines (Opens in a new window). Line 39: $header_patterns = array(Line 48: foreach ( $header_patterns as $header_pattern ) {Line 50: 'blockbase/header-' . $header_pattern,Line 52: 'title' => __( 'Blockbase Header (' . $header_pattern . ')', 'blockbase' ),Line 55: 'content' => file_get_contents (get_theme_file_path( '/parts/header-' . $header_pattern . '.html' )),

⚠️ WARNING (4)

- screenshot.png is 555.6 KB in size. Large file sizes have a negative impact on website performance and loading time. Compress images before using them. - Found a translation function that has an incorrect number of arguments in the file inc/block-patterns.php. Function __, with the arguments 'Blockbase Header (', ), 'blockbase'. Line 52: 'title' => __( 'Blockbase Header (' . $header_pattern . ')', 'blockbase' ), - Found a translation function that is missing a text-domain in the file inc/customizer/wp-customize-fonts.php. Function __, with the arguments 'https://wordpress.com/support/custom-fonts/'. Line 13: __( 'https://wordpress.com/support/custom-fonts/' ) - More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are blockbase, ).

---

geologist: No changes required ✅.

💡 RECOMMENDED (1)

- No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.

⚠️ WARNING (2)

- Found a translation function that is missing a text-domain in the file inc/customizer/wp-customize-fonts.php. Function __, with the arguments 'https://wordpress.com/support/custom-fonts/'. Line 13: __( 'https://wordpress.com/support/custom-fonts/' ) - More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are geologist, blockbase.

---

mayland-blocks: There are required changes on the theme ❌.

❎ REQUIRED

• Found a reference to unsplash.com. Assets from this website does not use a license that is compatible with GPL. View license (opens in a new window).
• This theme text domain does not match the theme's slug. The text domain used: blockbase, ) This theme's correct slug and text-domain is mayland-blocks.

💡 RECOMMENDED (2)

- No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes. - Possible variable $header_pattern found in translation function in inc/block-patterns.php. Translation function calls must not contain PHP variables, use placeholders instead. See Internationalization Guidelines (Opens in a new window). Line 39: $header_patterns = array(Line 48: foreach ( $header_patterns as $header_pattern ) {Line 50: 'blockbase/header-' . $header_pattern,Line 52: 'title' => __( 'Blockbase Header (' . $header_pattern . ')', 'blockbase' ),Line 55: 'content' => file_get_contents (get_theme_file_path( '/parts/header-' . $header_pattern . '.html' )),

ℹ️ INFO (1)

- Found wrong tag, remove auto-loading-homepage from your style.css header.

⚠️ WARNING (3)

- Found a translation function that has an incorrect number of arguments in the file inc/block-patterns.php. Function __, with the arguments 'Blockbase Header (', ), 'blockbase'. Line 52: 'title' => __( 'Blockbase Header (' . $header_pattern . ')', 'blockbase' ), - Found a translation function that is missing a text-domain in the file inc/customizer/wp-customize-fonts.php. Function __, with the arguments 'https://wordpress.com/support/custom-fonts/'. Line 13: __( 'https://wordpress.com/support/custom-fonts/' ) - More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are blockbase, ).

---

meraki: There are required changes on the theme ❌.

💡 RECOMMENDED (2)

- No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes. - Possible variable $header_pattern found in translation function in inc/block-patterns.php. Translation function calls must not contain PHP variables, use placeholders instead. See Internationalization Guidelines (Opens in a new window). Line 39: $header_patterns = array(Line 48: foreach ( $header_patterns as $header_pattern ) {Line 50: 'blockbase/header-' . $header_pattern,Line 52: 'title' => __( 'Blockbase Header (' . $header_pattern . ')', 'blockbase' ),Line 55: 'content' => file_get_contents (get_theme_file_path( '/parts/header-' . $header_pattern . '.html' )),

⚠️ WARNING (5)

- Found ="[jetpack_subscription_form show_subscribers_total='false' button_on_newline='true' custom_font_size='16px' custom_border_radius='50' custom_border_weight='1' custom_button_width='100%' custom_padding='15' custom_spacing='10' submit_button_classes='has-background-border-color has-text-color has-primary-color has-background has-background-background-color' email_field_classes='has-background-border-color' show_only_email_and_button='true' success_message=' __( 'Blockbase Header (' . $header_pattern . ')', 'blockbase' ), - Found a translation function that is missing a text-domain in the file inc/customizer/wp-customize-fonts.php. Function __, with the arguments 'https://wordpress.com/support/custom-fonts/'. Line 13: __( 'https://wordpress.com/support/custom-fonts/' ) - More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are meraki, blockbase, ).

ℹ️ INFO (1)

- Found wrong tag, remove auto-loading-homepage from your style.css header.

---

quadrat: No changes required ✅.

💡 RECOMMENDED (1)

- No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.

ℹ️ INFO (1)

- Found wrong tag, remove auto-loading-homepage from your style.css header.

⚠️ WARNING (2)

- Found a translation function that is missing a text-domain in the file inc/customizer/wp-customize-fonts.php. Function __, with the arguments 'https://wordpress.com/support/custom-fonts/'. Line 13: __( 'https://wordpress.com/support/custom-fonts/' ) - More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are quadrat, blockbase.

---

russell: There are required changes on the theme ❌.

❎ REQUIRED

• Found a reference to unsplash.com. Assets from this website does not use a license that is compatible with GPL. View license (opens in a new window).
• Screenshot is wrong size! Detected: 1200x906. Maximum allowed size is 1200x900px.
• Screenshot dimensions are wrong! Ratio of width to height should be 4:3.
• This theme text domain does not match the theme's slug. The text domain used: blockbase, ) This theme's correct slug and text-domain is russell.

💡 RECOMMENDED (3)

- No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes. - Possible variable $header_pattern found in translation function in inc/block-patterns.php. Translation function calls must not contain PHP variables, use placeholders instead. See Internationalization Guidelines (Opens in a new window). Line 39: $header_patterns = array(Line 48: foreach ( $header_patterns as $header_pattern ) {Line 50: 'blockbase/header-' . $header_pattern,Line 52: 'title' => __( 'Blockbase Header (' . $header_pattern . ')', 'blockbase' ),Line 55: 'content' => file_get_contents (get_theme_file_path( '/parts/header-' . $header_pattern . '.html' )), - Screenshot size should be 1200x900, to account for HiDPI displays. Any 4:3 image size is acceptable, but 1200x900 is preferred.

⚠️ WARNING (4)

- screenshot.png is 535.5 KB in size. Large file sizes have a negative impact on website performance and loading time. Compress images before using them. - Found a translation function that has an incorrect number of arguments in the file inc/block-patterns.php. Function __, with the arguments 'Blockbase Header (', ), 'blockbase'. Line 52: 'title' => __( 'Blockbase Header (' . $header_pattern . ')', 'blockbase' ), - Found a translation function that is missing a text-domain in the file inc/customizer/wp-customize-fonts.php. Function __, with the arguments 'https://wordpress.com/support/custom-fonts/'. Line 13: __( 'https://wordpress.com/support/custom-fonts/' ) - More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are blockbase, ).

ℹ️ INFO (1)

- Found wrong tag, remove auto-loading-homepage from your style.css header.

---

seedlet-blocks: No changes required ✅.

ℹ️ INFO (1)

- Found wrong tag, remove auto-loading-homepage from your style.css header.

⚠️ WARNING (2)

- Found a translation function that is missing a text-domain in the file inc/customizer/wp-customize-fonts.php. Function __, with the arguments 'https://wordpress.com/support/custom-fonts/'. Line 13: __( 'https://wordpress.com/support/custom-fonts/' ) - More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are seedlet-blocks, blockbase.

---

zoologist: There are required changes on the theme ❌.

❎ REQUIRED

• This theme text domain does not match the theme's slug. The text domain used: blockbase, ) This theme's correct slug and text-domain is zoologist.

💡 RECOMMENDED (2)

- No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes. - Possible variable $header_pattern found in translation function in inc/block-patterns.php. Translation function calls must not contain PHP variables, use placeholders instead. See Internationalization Guidelines (Opens in a new window). Line 39: $header_patterns = array(Line 48: foreach ( $header_patterns as $header_pattern ) {Line 50: 'blockbase/header-' . $header_pattern,Line 52: 'title' => __( 'Blockbase Header (' . $header_pattern . ')', 'blockbase' ),Line 55: 'content' => file_get_contents (get_theme_file_path( '/parts/header-' . $header_pattern . '.html' )),

⚠️ WARNING (3)

- Found a translation function that has an incorrect number of arguments in the file inc/block-patterns.php. Function __, with the arguments 'Blockbase Header (', ), 'blockbase'. Line 52: 'title' => __( 'Blockbase Header (' . $header_pattern . ')', 'blockbase' ), - Found a translation function that is missing a text-domain in the file inc/customizer/wp-customize-fonts.php. Function __, with the arguments 'https://wordpress.com/support/custom-fonts/'. Line 13: __( 'https://wordpress.com/support/custom-fonts/' ) - More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are blockbase, ).

---

[renatho]

I'm skipping the "Theme-Check results" since it's not related to the changes in this PR.

[allilevine]

I tested on Arbutus and Blockbase and I was able to change the heading levels and see the correct font size changes, both in the editor and on the live site. After that I couldn't get the site editor to load, it seems like a Playground issue.

[renatho]

Hi @Automattic/theam! 👋 Would some of you have the opportunity to take a look at this PR to solve the issue? Or is there anyone more involved with these themes that we could add as a reviewer?