Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
https://themeshaper.com
GNU General Public License v2.0
903 stars 357 forks source link

[DotCom Launch]: Raconteur #8201

Closed iamtakashi closed 1 month ago

iamtakashi commented 1 month ago

DotCom launch checklist

iamtakashi commented 1 month ago

There was an issue with some fonts in the theme, but now it's fixed. Once the theme gets deployed to WP.com, it should be ready.

alaczek commented 1 month ago

I noticed a few things about this theme that I want to make sure are intentional.

  1. The left and right columns repeat on every page, but are not template parts - instead the same code is repeated in single.php, page.php, search.php, home.php - basically any pattern that corresponds to a template. Is there a reason for this?
  2. There are subtle color changes between the home and internal pages - the site title and description are blue on home, but black elsewhere. Similarly, the right column is pink on home, while it has white bg elsewhere. Was this intentional?

Homepage:

image

Single post:

image

The overlay menu is also looking slightly different, plus longer items are not centre-aligned (see "Contact Form")

Homepage:

image

Single page:

image

Lastly, could we remove the copyright line "© 2024"?

I can open a separate issue for this if that helps.

henriqueiamarino commented 1 month ago

Thanks, @alaczek! I have fixed the color discrepancies on all templates at this PR #8204

Unfortunately, I don't know how to use patterns to display the alternate posts on the front page. If you think it is possible, please let me know how, and I'll fix this, too.

alaczek commented 1 month ago

Thanks for tackling the colors!

Unfortunately, I don't know how to use patterns to display the alternate posts on the front page.

Are you referring to this comment of mine: "The left and right columns repeat on every page, but are not template parts"? If so, I didn't mean the posts, I meant the thin sidebars/columns on the left and right - these would ideally be reusable template parts, because they repeat on every page:

Image

henriqueiamarino commented 1 month ago

Oh, right, I should have done that as my last task and forgot about it. All templates now have column contents set as Header and Navbar, with the exception of the front page, which got a Navbar Home. This is working at #8204.

iamtakashi commented 1 month ago

@alaczek This should be ready to go after the latest updates get deployed to dotcom.