Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
https://themeshaper.com
GNU General Public License v2.0
905 stars 357 forks source link

Dalston theme: Hover Reveal style not hiding the color background on WordPress 5.9 #8395

Open renatho opened 2 weeks ago

renatho commented 2 weeks ago

Quick summary

The color/gradient background is not hidden when using the "Hover Reveal".

I noticed this issue as part of https://github.com/Automattic/themes/pull/8385, and I didn't fix to avoid creating issues with other versions since it's happening only with WP 5.9. Anyway, I'm creating this issue to document it in case we want to fix it in the future.

Steps to reproduce

  1. Create a site with WP 5.9
  2. Add a cover block with an image or video
  3. Add a color or gradient to the cover.
  4. Select the "Hover Reveal" style.

A clear and concise description of what you expected to happen.

The color/gradient should be hidden, and revealed with the content only on hover.

Video from WP 6.6:

https://github.com/user-attachments/assets/dd5dbfaa-7ccf-4da6-aeff-b50befd21026

What actually happened

The color/gradient background is not hidden.

https://github.com/user-attachments/assets/273ba820-8c12-4348-bff4-8238a7bc9d23

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

No response

Logs or notes

Theme Dalston WordPress 5.9

renatho commented 2 weeks ago

Adding a Low priority label since it's only on WP 5.9 and the impact is not very significant.

alaczek commented 4 days ago

Can we close this as fixed?

renatho commented 4 days ago

Can we close this as fixed?

Hi, @alaczek! Do you mean because it's a low-priority issue?

alaczek commented 3 days ago

Because I saw you merged a fix above? Or did this not fix the issue?

renatho commented 3 days ago

Because I saw you merged a fix above? Or did this not fix the issue?

Ah! I see. Maybe you are referring to this PR, right? If yes, this wasn't fixed. I opened this issue to keep track because the issue still happens on WP 5.9. :)