Automattic / twenty-nineteen-amp-prototype

2 stars 2 forks source link

AMP validation error regarding CSS with i-amphtml-* class selectors #4

Open westonruter opened 5 years ago

westonruter commented 5 years ago

I noticed the AMP validator complaining with:

The text inside tag 'style amp-custom' contains 'CSS i-amphtml- name prefix', which is disallowed.

This is due these rules:

https://github.com/Automattic/twenty-nineteen-amp-prototype/blob/fe8c1cd6665f2b4701fb44e1cce59bed5810d740/sass/navigation/_menu-main-navigation.scss#L639-L653

I suggest replacing [class*="i-amphtml-accordion-header"] with amp-accordion > section > h2