search

Automattic / underscores.me

https://underscores.me
GNU General Public License v2.0
210 stars 118 forks source link

Update feature list language to match _s readme. #24

Closed lchski closed 7 years ago

lchski commented 10 years ago

As I mentioned in Automattic/_s#533, I’ve updated the feature list to fix the differences between the main repo’s list and the list on http://underscores.me.

What I didn’t include, though, were instructions that are in the _s readme about how to implement features, because I didn’t think they were necessary on the site. Once a user has downloaded a version of _s, they probably won’t return to the website to figure out how to implement a feature, being more likely to turn to the repo itself.

If it seems necessary to include the instructions on the website, then I’ll do that, too.

obenland commented 10 years ago

IMO we should keep the trailing slash for directories around, to make it clear they are directories. Files will have file endings, and directories the trailing slash.

Other than that, it's good to go from my end.

lchski commented 10 years ago

Ah, I removed that on account of it having been removed in my previous PR to this effect, Automattic/_s#269. That slash should probably be re-added over in the _s readme, then. I’ll remove it here.

davidakennedy commented 7 years ago

Thanks for the pull request @lchski!