Closed rdswd closed 7 years ago
Hey there @rdswd!
Thanks for the awesome pull request, and your patience! We should have got to this sooner. :smile:
When I tested this, it output the <p>
tags as you had them in the code. Like this:
https://cloudup.com/cQ9B4suaJCw
Using "\n\n"
should solve that. It will preserve the line breaks where they need to be, and the double quotes is so PHP recognizes them as line new lines. I'd also add some spaces around the .
for concatenation just so it's more readable. Make sense?
So:
$contents = preg_replace('/(?<=Description ==) *.*?(.*(?=(== Installation)))/s', "\n\n" . $this->theme['description'] . "\n\n", $contents );
Would you like to update your pull request, and I'll test and merge?
No problem. I made the change as per your suggestion. I wasn't able to test as I couldn't get the local theme to build the zip file properly (I figured this out during the initial pull but can't remember what I did).
Pull request made.
Thanks for the pull request @rdswd! Better late than never, as they say. 😄
No problem! I've been using _'s forever so this made my day.
This removes the description and puts in the theme description as inputted by the underscores.me user. It also removes the awkward ', or underscores' the follows the underscores.me user's theme name above the description.
Currently the readme.txt shows this under the license uri:
A starter theme called chosen-theme-name, or underscores.
== Description ==
Hi. I'm a starter theme called chosen-theme-name, or underscores, if you like. I'm a theme meant for hacking so don't use me as a Parent Theme. Instead try turning me into the next, most awesome, WordPress theme out there. That's what I'm here for.