search

Automattic / underscores.me

https://underscores.me
GNU General Public License v2.0
210 stars 118 forks source link

Replace _s by theme-slug for text_domain value in phpcs ruleset file #56

Open truongwp opened 7 years ago

truongwp commented 7 years ago

Related #54

jrfnl commented 7 years ago

Related ? You mean duplicate, I presume ?

grappler commented 7 years ago

@jrfnl #56 is a PR and #54 is an issue.

jrfnl commented 7 years ago

@grappler Thanks for putting me right.

In that case, shouldn't it be: Fixes #54 ? :+1:

truongwp commented 7 years ago

@jrfnl Like you said in the issue:

The _s in the below snippet is not being replaced by the generator at this time. Once WPCS 0.12.0 comes out, a second customization will be added, which will also take _s as an property value, so let's keep this issue open until this is handled correctly.

So I'm not sure this will be merged or wait for WPCS 0.12.0, so I am not sure it should be "Fixes"

jrfnl commented 7 years ago

@truongwp Partially fixes maybe ? Thanks for creating the PR!

davidakennedy commented 7 years ago

Thanks for the pull request @truongwp! It may be better to go ahead and wait for WPCS 0.12.0 so everything can be fixed at once.

MehbubRashid commented 3 years ago

Hi @davidakennedy this problem still existing in 2021