Automattic / underscores.me

https://underscores.me
GNU General Public License v2.0
210 stars 118 forks source link

Textdomain slugs #6

Closed obenland closed 11 years ago

obenland commented 11 years ago

For textdomains, spaces should be replaced by hyphens rather than underscores.

Just noticed it when generating Wu Wei. Did this change recently? :)

kovshenin commented 11 years ago

It didn't. The slug always had underscores instead of spaces/hyphens because hyphens are illegal in function names. Do you think there's a way we can differentiate between a callback function string and a text domain?

obenland commented 11 years ago

Callback functions should start with '_s_', while textdomains are '_s'.

kovshenin commented 11 years ago

Fixed in #10