search

Automattic / vip-block-data-api

WordPress plugin that provides an API to retrieve Gutenberg content as structured JSON.
http://wpvip.com
GNU General Public License v3.0
103 stars 7 forks source link

PHPDocs and Typehints #41

Open tomjn opened 1 year ago

tomjn commented 1 year ago

Describe the bug

There's almost no type hinting in the plugin, and half the methods are missing PHPDocs.

To Reproduce

look at the code, I would have expected the VIP PHPCS rules to have flagged the missing PHPDocs, or WPCS. PHStan should be kicking up a fuss about it too

Version of the plugin 1.0.1

ingeniumed commented 1 year ago

@tomjn Thanks for flagging this, I agree with you on getting this added in. We will work on getting this resolved 👍🏾

ingeniumed commented 1 year ago

PHPDocs are in, type hinting is what's left to be added in.