Automattic / vip-cli

The VIP-CLI
https://docs.wpvip.com/vip-cli/
MIT License
59 stars 16 forks source link

feat(dev-env): add support for cron #1892

Closed sjinks closed 4 months ago

sjinks commented 4 months ago

Description

This PR adds support for cron (cron-control-runner) to the dev env.

~Depends on: Automattic/cron-control-runner#26~ ~Depends on: Automattic/cron-control-runner#27~ ~Depends on: Automattic/vip-container-images#783~

(it still can run without the PRs above; the only difference is that the system cron daemon will be used instead of cron-control-runner)

It introduces a new option to vip dev-env create and vip dev-env update:

    -c, --cron                    Enable or disable cron, disabled by default. Accepts "y" (default value) to enable or "n" to disable.

Pull request checklist

New release checklist

Steps to Test

Outline the steps to test and verify the PR here.

Example:

  1. vip dev-env create --cron < /dev/null
  2. vip dev-env start
  3. vip dev-env shell
  4. ps aux and verify that there is either cron or cron-control-runner running.
github-actions[bot] commented 4 months ago

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud