sjinks commented 4 months ago

Description

Healthcheck fails if the server replies with a 404 error. However, it is possible to (mis)configure WordPress to reply with 404 when its home page is accessed.

This PR sets waitable codes to 502 (Bad gateway) and 504 (Gateway timeout) to avoid false negatives on whether the environment is down.

Pull request checklist

[ ] Update SETUP.md with any new environmental variables.
[ ] Update the documentation.
[x] Manually test the relevant changes.
[x] Follow the pull request checklist
[ ] Add/update automated tests as needed.

New release checklist

[ ] Automated tests pass.
[ ] The Preparing for release checklist is completed.

Steps to Test

N/A

github-actions[bot] commented 4 months ago

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Manifest Files

sonarcloud[bot] commented 4 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Automattic / vip-cli

fix(dev-env): retry healthcheck only on 502 and 504 status codes #1896