Automattic / vip-cli

The VIP CLI
https://docs.wpvip.com/vip-cli/
MIT License
58 stars 16 forks source link

fix(dev-env): display all port mappings #1914

Closed sjinks closed 2 months ago

sjinks commented 2 months ago

Description

This PR updates the getExtraServicesConnections() function to return all port mappings instead of only the first one (which can be random). This fix makes it possible to display custom port mappings set by the user in .lando.local.yml

Pull request checklist

New release checklist

Steps to Test

Outline the steps to test and verify the PR here.

Example:

  1. Create a test environment
  2. Add a custom port mapping in .lando.local.yml:
    services:
    database:
    type: compose
    services:
      ports:
        - "13306:3306"
  3. Start the environment.
  4. Verify that the Database service has two addresses (127.0.0.1:random_port and 127.0.0.1:13306).
github-actions[bot] commented 2 months ago

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud