Automattic / vip-cli

The VIP CLI

https://docs.wpvip.com/vip-cli/

MIT License

58 stars 16 forks source link

refactor(dev-env): do not load SSH keys #1934

Closed sjinks closed 1 month ago

sjinks commented 1 month ago

Description

Do not load SSH keys into all services to save some time. This improves security and slightly reduces startup time.

This also keeps /var/www clean. We will then be able to mirror the directory structure of production environments for better compatibility.

Related: Automattic/lando-cli#78

Pull request checklist

[ ] Update SETUP.md with any new environmental variables.
[ ] Update the documentation.
[x] Manually test the relevant changes.
[ ] Follow the pull request checklist
[ ] Add/update automated tests as needed.

New release checklist

[ ] Automated tests pass.
[ ] The Preparing for release checklist is completed.

Steps to Test

CI must pass.

github-actions[bot] commented 1 month ago

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Manifest Files

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud