Add saveErrorLog flag to import media command

kevinfodness commented 2 months ago

Description

Adds a --saveErrorLog flag to the import media command to allow the user to bypass the confirmation prompt for saving an error log if it is generated.

Fixes #2004

Pull request checklist

[X] Update SETUP.md with any new environmental variables.
[X] Update the documentation.
[X] Manually test the relevant changes.
[X] Follow the pull request checklist
[X] Add/update automated tests as needed.

New release checklist

[ ] Automated tests pass.
[ ] The Preparing for release checklist is completed.

Steps to Test

Note: I was not able to get the vip command to run locally in my tests - it was erroring with Error: spawn vip.js-import ENOENT and I'm not sure how to get around this. Hopefully an Automattician can help to test this change or provide me with instructions on how to test locally.

Check out PR.
Run npm run build
Run ./dist/bin/vip.js import media with the new --saveErrorLog flag set targeting an archive that contains a file that will error.
Confirm that the error log is saved without user input.

aswasif007 commented 2 months ago

Hi @kevinfodness 👋 Instead of adding --saveErrorLog flag, I think it is better to make sure that the --force flag bypass the prompt in question. I've raised a PR for that: https://github.com/Automattic/vip-cli/pull/2011

aswasif007 commented 2 months ago

Many thanks for working on this PR, @kevinfodness 👏