aswasif007 commented 2 months ago

Issue

https://github.com/Automattic/vip-cli/issues/2005

Description

In the vip import media command, when all files in the archive fails/errors while importing, the import does not show the success/total count in the end. This is because of a bug in the null-check filter where the case of filesProcessed = 0 is being consumed by the null check.

Pull request checklist

[ ] Update SETUP.md with any new environmental variables.
[ ] Update the documentation.
[ ] Manually test the relevant changes.
[ ] Follow the pull request checklist
[ ] Add/update automated tests as needed.

Steps to Test

Check out PR.
Run npm run build
Run node ./dist/bin/vip import media @<app>.<env> https://getsamplefiles.com/download/zip/sample-1.zip twice. In the second run, all the files should fail to import as they are already imported. When that happens, make sure that the Imported Files: 0/4 - 0% ✓ line is present in the output.