t-wright commented 2 months ago

Description

When importing SQL to a multisite environment, we check that the SQL file is from a multisite installation. One of the ways we do that is by checking the table name in CREATE TABLE statements are in a format like wp_\d_posts. However our regex doesn't currently match if the IF NOT EXISTS keyword is present, leading to a validation warning. This PR fixes that.

Pull request checklist

[ ] Update SETUP.md with any new environmental variables.
[ ] Update the documentation.
[x] Manually test the relevant changes.
[ ] Follow the pull request checklist
[x] Add/update automated tests as needed.

New release checklist

[ ] Automated tests pass.
[ ] The Preparing for release checklist is completed.

Steps to Test

Create an SQL file with these contents:

DROP TABLE IF EXISTS `wp_5_postmeta`;

CREATE TABLE IF NOT EXISTS `wp_5_postmeta` (
  `meta_id` bigint unsigned NOT NULL AUTO_INCREMENT,
  `post_id` bigint unsigned NOT NULL DEFAULT '0',
  `meta_key` varchar(255) CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci DEFAULT NULL,
  `meta_value` longtext CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci,
  PRIMARY KEY (`meta_id`),
  KEY `post_id` (`post_id`),
  KEY `vip_meta_key_value` (`meta_key`(191),`meta_value`(100))
) ENGINE=InnoDB AUTO_INCREMENT=105388 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;

Check out PR.
Run npm run build
Run ./dist/bin/vip-import-sql.js path_to_file.sql @<id>.production (where the id corresponds to a multisite installation)
Verify you do not receive the error: Error: You have requested a subsite SQL import but have not provided a subsite compatiable SQL dump.