sjinks commented 1 month ago

Description

In #1896, we removed the 404 code from the list of "unhealthy" codes. However, that introduced a bug: if Traefik cannot find a container matching the host, it returns a 404 response. Because of that, all environments are shown as "UP."

In this PR, we ensure service containers are running before starting a URL scan.

Pull request checklist

[ ] Update SETUP.md with any new environmental variables.
[ ] Update the documentation.
[x] Manually test the relevant changes.
[x] Follow the pull request checklist
[ ] Add/update automated tests as needed.

New release checklist

[ ] Automated tests pass.
[ ] The Preparing for release checklist is completed.

Steps to Test

Create two environments.
Start one of them
Run vip dev-env list or vip dev-env info -s slug_of_not_running_env: even if the environment is not running, it will be shown as "UP."
Apply the patch and ensure the problem hs gone away.