sjinks commented 3 weeks ago

Description

This PR fixes the generation of a map of domains to replace for a multisite environment.

Previously, if a site URL contained a path (e.g., https://domain.com/path), such an URL would be replaced with slug.vipdev.site because the system compared domain.com/path to domain.com and ignored it because the strings are not equal.

This PR fixes the procedure by comparing domains instead.

Pull request checklist

[ ] Update SETUP.md with any new environmental variables.
[ ] Update the documentation.
[x] Manually test the relevant changes.
[x] Follow the pull request checklist
[ ] Add/update automated tests as needed.

New release checklist

[ ] Automated tests pass.
[ ] The Preparing for release checklist is completed.

Steps to Test

See the ticket.

github-actions[bot] commented 3 weeks ago

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Files

sonarcloud[bot] commented 2 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Automattic / vip-cli

fix(dev-env): detection of URLs to replace for multisites #2081