Automattic / vip-cli

The VIP-CLI

https://docs.wpvip.com/vip-cli/

MIT License

58 stars 17 forks source link

fix: `table` format output #2096

Closed sjinks closed 2 weeks ago

sjinks commented 2 weeks ago

Description

This PR enables the table format option for the vip logs command to work as expected and for table to be the default output format.

See: BB8-11593

Pull request checklist

[ ] Update SETUP.md with any new environmental variables.
[ ] Update the documentation.
[x] Manually test the relevant changes.
[x] Follow the pull request checklist
[ ] Add/update automated tests as needed.

New release checklist

[ ] Automated tests pass.
[ ] The Preparing for release checklist is completed.

Steps to Test

Compare the output of vip logs @env with and without this patch.

github-actions[bot] commented 2 weeks ago

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Files

sonarcloud[bot] commented 2 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

rinatkhaziev commented 2 weeks ago

Are we sure we want the table a default format?

yolih commented 2 weeks ago

Whenever possible, VIP-CLI commands that support the --format option should adhere to a standard set of options and default patterns, even if the options and defaults might not seem logical. Adhering to a pattern makes an option more intuitive for a customer to use without having to consult the --help menu. https://veetoop2.wordpress.com/2024/04/16/standardizing-the-format-option-in-vip-cli/