Automattic / vip-cli

The VIP-CLI
https://docs.wpvip.com/vip-cli/
MIT License
58 stars 17 forks source link

Add --format="text" option to vip logs #2121

Closed owen-cole closed 1 day ago

owen-cole commented 4 days ago

Description

In https://github.com/Automattic/vip-cli/pull/2089 the table option was formatted to meet a style guide's requirements. I see the default option was actually previously table but not formatted as a table so this change makes sense.

The previous basic text format was nice to have especially when using the --follow flag and matches what is described here https://docs.wpvip.com/logs/runtime-logs/cli/

The docs mention an option for formatting called text and this PR enables that option and restores the previous formatting of the logs under that option: https://github.com/Automattic/vip-cli/blame/19c65e4758b30be5d9708ae807f754f2a6883ef1/src/bin/vip-logs.js#L146-L151

Pull request checklist

New release checklist

Steps to Test

Outline the steps to test and verify the PR here.

Example:

  1. Check out PR.
  2. Run npm run build
  3. Run ./dist/bin/vip-cookies.js nom
  4. Verify cookies are delicious.
sonarcloud[bot] commented 1 day ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud