search

Automattic / vip-container-images

Multipurpose VIP Docker container images (primarily meant for use with the VIP Local Development Environment)
https://docs.wpvip.com/technical-references/vip-local-development-environment/
16 stars 4 forks source link

feat(dev-env): migration from `vipdev.lndo.site` to `vipdev.site` #851

Open sjinks opened 2 months ago

github-actions[bot] commented 2 months ago

Trivy Scan Report

ghcr.io/automattic/vip-container-images/dev-tools:0.9 (alpine 3.20.3)

No vulnerabilities found.

rebeccahum commented 2 months ago

How do we make sure we don't break things for existing dev-env users who aren't running on the latest CLI? 😬

sjinks commented 2 months ago

@rebeccahum Images are updated independently of VIP CLI.

For the existing environments, images are re-pulled every two weeks. For new environments, they are pulled on the first start.

The idea is to merge this PR and ship Automattic/vip-cli#1984, say, in a month.

rinatkhaziev commented 1 month ago

For the existing environments, images are re-pulled every two weeks. For new environments, they are pulled on the first start.

@sjinks Right, but then it means someone on the old version will download the new image and the migration routine will run for them?

sjinks commented 1 month ago

@rinatkhaziev

https://github.com/Automattic/vip-container-images/pull/851/files#diff-ad8cc8dcf9efb7506300a53b2cf5754bf370da1daa148bf33304572c6a8050f7R206

The migration routine will start if the new domain is *.vipdev.site and the siteurl mentions vipdev.lndo.site. That is, the migration will never happen for the old versions of VIP CLI.

rinatkhaziev commented 1 month ago

@rebeccahum ideally we should test a bit :)

rebeccahum commented 1 month ago

@rinatkhaziev testing? don't know her

rinatkhaziev commented 1 month ago

Testing, please meet @rebeccahum. Rebecca, please meet Testing, our good friend.

sjinks commented 1 month ago

@rebeccahum @rinatkhaziev is it ok to merge this? Or are you still having fun with Testing?

rebeccahum commented 1 month ago

@sjinks Haven't reached out to Testing yet, are you able to?

sjinks commented 1 month ago

I actually did :-) (like a month ago)

This is what we were doing:

  1. Create, start, and stop a new environment (it should be in vipdev.lndo.site)
  2. Update Lando config (~/.local/share/vip/lando/config.yml) and set domain: vipdev.site
  3. Make sure that no other environment is running and there's no proxy container hanging around. If they are, kill them.
  4. Restart the environment; it should say "Migrating from vipdev.lndo.site to vipdev.site, please stand by…"
  5. Make sure that the new ....vipdev.site URL works.
rinatkhaziev commented 1 month ago

I'm gonna try to break it, stay tuned.