Adjust checkbox/radio with indeterminate rules and less examples - Githubissues

Automattic / vip-design-system

Design system components used throughout WordPress VIP

https://vip-design-system-components.netlify.app/

15 stars 3 forks source link

Adjust checkbox/radio with indeterminate rules and less examples #367

Closed djalmaaraujo closed 5 months ago

djalmaaraujo commented 5 months ago

Description

As agreed, we will:

[x] Remove the extra variants from examples (success)
[x] Update the checkbox with the indeterminate state
[x] Match color and styles

Checklist

[x] This PR has good automated test coverage
[x] The storybook for the component has been updated

Steps to Test

Pull down PR.
npm run dev.
Open http://localhost:6006/?path=/story/form-radio--default
No more success state
Open http://localhost:6006/?path=/story/form-checkbox--indeterminate
Indeterminate state is implemented as Figma shows
No more success variants. Keep primary and brand in all controles for now.

netlify[bot] commented 5 months ago

Deploy Preview for vip-design-system-components ready!

Name	Link
Latest commit	2f0ffd790153229eecef0ebf6734aae66ba2d808
Latest deploy log	https://app.netlify.com/sites/vip-design-system-components/deploys/66036c8bc8c67d00084e080f
Deploy Preview	https://deploy-preview-367--vip-design-system-components.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.