Automattic / vip-design-system

Design system components used throughout WordPress VIP
https://vip-design-system-components.netlify.app/
14 stars 3 forks source link

Adjust tabs selected styling and the responsiveness behavior #384

Closed djalmaaraujo closed 3 months ago

djalmaaraujo commented 3 months ago

Description

Checklist

Steps to Test — Responsiveness Behavior

chrome-capture-2024-5-1 (1)

  1. Pull down PR.
  2. npm run dev.
  3. Open http://localhost:6006/?path=/story/navigation-nav--tab
  4. Reduce the viewport smaller than the tab items size
  5. Expect to have a horizontal scrollbar

Steps to Test — Box shadow bug

  1. Pull down PR.
  2. npm run dev.
  3. Open http://localhost:6006/?path=/story/navigation-nav--tab
  4. By using the device toolbar in Chrome, put on a iPhone XR size with 50% of zoom
image
  1. Expect to have the selected item with a bottom border and not left/right borders (see screenshot above)
Before After
image

|

image

|

netlify[bot] commented 3 months ago

Deploy Preview for vip-design-system-components ready!

Name Link
Latest commit 0f573b2fe32c10bd8abc4dfed39318796226bc58
Latest deploy log https://app.netlify.com/sites/vip-design-system-components/deploys/663236109d8e6c00082cb500
Deploy Preview https://deploy-preview-384--vip-design-system-components.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.