search

Automattic / vip-design-system

Design system components used throughout WordPress VIP
https://vip-design-system-components.netlify.app/
14 stars 3 forks source link

LinkExternal: migrate from dashboard #390

Closed brookewp closed 3 months ago

brookewp commented 3 months ago

Summary

We're planning to migrate the footer from the dashboard (#373), which contains the LinkExternal component. To make that migration easier, I figured I'd start here.

Details

In the first commit https://github.com/Automattic/vip-design-system/commit/0ecdce962fda7504bb8ed9e6c97394a48b26cd0a, it's 1:1 with the dashboard, just for ease of comparing the following changes in subsequent commits. But mostly, I've kept the component the same. I checked in with @djalmaaraujo to see if we wanted to use this as an opportunity to change anything about the component or if we want to keep it the same for a smoother migration. I initially thought we might want an isExternal prop on the existing <Link/> component, but I want to ensure I follow the standards set here. 🙂

Checklist

Steps to Test

  1. Pull down PR.
  2. npm run dev.
  3. Open Storybook.
  4. Navigate to LinkExternal component
  5. Verify component works the same as the dashboard component
netlify[bot] commented 3 months ago

Deploy Preview for vip-design-system-components ready!

Name Link
Latest commit 423eea1d22a4179a39e9be382b7bfefb5e5d62fb
Latest deploy log https://app.netlify.com/sites/vip-design-system-components/deploys/663d6dc157805c00089fc20d
Deploy Preview https://deploy-preview-390--vip-design-system-components.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.