Closed ariskataoka closed 2 years ago
Is the same fix needed for the wget as well?
Is the same fix needed for the wget as well?
No one has mentioned that, but I'd assume it would be necessary as well. Nice catch!
I've rebased signing and pushing my commits, but it seems GH didn't recognize them. So I've closed the PR, and I'm reopening it now to see if GH recognizes them in this branch.
No issues were found to report when scanning latest commit (commit-ID: 28039283a7fbcf2002497c1020e762bb16ee8d48)
This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.
Software versions
Options file (
|
PHP lint optionsPHP lint files enabled:
Lint modified files only:
Directories not PHP linted:
SVG configurationSVG scanning enabled:
Auto-approval configurationAuto-approvals enabled:
Non-functional changes auto-approved:
Auto-approved file-types:
|
PHPCS configurationPHPCS scanning enabled:
PHPCS severity level:
Standard(s) used:
Runtime set:
Custom sniffs included:
Custom sniffs excluded:
Directories not PHPCS scanned:
|
install.sh
script, executesbrew install
for the project dependencies. And it incorrectly adds a blank string before the name of the dependency.This PR addresses the issue by adding a verification that will only add the blank space when the TMP_INSTALL var contains a value.
check_utility
function execution as well. Functions that exist were pointed out as missing, eg. shasum.This PR addresses it by checking the utility's existence by verifying the exit codes 127 and 126, which are the ones returned by the OS for non-existent/non-executable commands.
TODO: