Automattic / vip-go-compatibility-scanner

Scan for compatibility problems in repository code using PHPCS with any standard, report as GitHub issues.
5 stars 1 forks source link

Fix md5sha1sum install #35

Closed ariskataoka closed 2 years ago

ariskataoka commented 2 years ago
  1. The install.sh script, executes brew install for the project dependencies. And it incorrectly adds a blank string before the name of the dependency.

This PR addresses the issue by adding a verification that will only add the blank space when the TMP_INSTALL var contains a value.

  1. There's a false negative during the check_utility function execution as well. Functions that exist were pointed out as missing, eg. shasum.

This PR addresses it by checking the utility's existence by verifying the exit codes 127 and 126, which are the ones returned by the OS for non-existent/non-executable commands.

TODO:

GaryJones commented 2 years ago

Is the same fix needed for the wget as well?

ariskataoka commented 2 years ago

Is the same fix needed for the wget as well?

No one has mentioned that, but I'd assume it would be necessary as well. Nice catch!

ariskataoka commented 2 years ago

I've rebased signing and pushing my commits, but it seems GH didn't recognize them. So I've closed the PR, and I'm reopening it now to see if GH recognizes them in this branch.

wpcomvip-vipgoci-bot commented 2 years ago

No issues were found to report when scanning latest commit (commit-ID: 28039283a7fbcf2002497c1020e762bb16ee8d48)


This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.



Scan run detail

Software versions

  • vip-go-ci version: 1.2.6
  • PHP runtime version for vip-go-ci: 8.1.10
  • PHP runtime for linting:
    • PHP 7.4: 7.4.30
  • PHP runtime version for PHPCS: 7.4.30
  • PHPCS version: 3.7.1
  • PHP runtime version for SVG scanner: 7.4.30

Options file (.vipgoci_options)

Options file enabled: true

Configurable options:

  • skip-execution
  • skip-draft-prs
  • lint-modified-files-only
  • phpcs
  • phpcs-severity
  • phpcs-sniffs-include
  • phpcs-sniffs-exclude
  • report-no-issues-found
  • review-comments-sort
  • review-comments-include-severity
  • post-generic-pr-support-comments
  • review-comments-sort
  • scan-details-msg-include
  • svg-checks
  • autoapprove
  • autoapprove-php-nonfunctional-changes

Options altered:

  • None

PHP lint options

PHP lint files enabled: true

Lint modified files only: true

Directories not PHP linted:

  • None

SVG configuration

SVG scanning enabled: true

Auto-approval configuration

Auto-approvals enabled: true

Non-functional changes auto-approved: true

Auto-approved file-types:

  • css
  • csv
  • eot
  • gif
  • gz
  • ico
  • ini
  • jpeg
  • jpg
  • json
  • less
  • map
  • md
  • mdown
  • mo
  • mp4
  • otf
  • pcss
  • pdf
  • po
  • pot
  • png
  • sass
  • scss
  • styl
  • ttf
  • txt
  • woff
  • woff2
  • yml

PHPCS configuration

PHPCS scanning enabled: true

PHPCS severity level: 1

Standard(s) used:

  • PHPCompatibility
  • PHPCompatibilityParagonieRandomCompat
  • PHPCompatibilityParagonieSodiumCompat
  • VariableAnalysis
  • WordPress

Runtime set:

  • testVersion 7.4-

Custom sniffs included:

  • None

Custom sniffs excluded:

  • None

Directories not PHPCS scanned:

  • None