Automattic / vip-go-compatibility-scanner

Scan for compatibility problems in repository code using PHPCS with any standard, report as GitHub issues.
5 stars 1 forks source link

Fix md5sha1sum install - signed commits #37

Closed ariskataoka closed 2 years ago

ariskataoka commented 2 years ago
  1. The install.sh script, executes brew install for the project dependencies. And it incorrectly adds a blank string before the name of the dependency.

This PR addresses the issue by adding a verification that will only add the blank space when the TMP_INSTALL var contains a value.

  1. There's a false negative during the check_utility function execution as well. Functions that exist were pointed out as missing, eg. shasum.

This PR addresses it by checking the utility's existence by verifying the exit codes 127 and 126, which are the ones returned by the OS for non-existent/non-executable commands.

TODO: