ACL: Default to restricting all on non-prod if ACL is enabled but no options are set

rebeccahum commented 2 months ago

Description

If ACL is enabled but no options are explicitly set, we should default non-prods to use vip_files_acl_restrict_all_enabled.

Changelog Description

Changed

Non-prods: If ACL is enabled but no options are explicitly set, we should default to using vip_files_acl_restrict_all_enabled.

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

[ ] This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
[x] This change works and has been tested on a sandbox.
[ ] This change has relevant unit tests (if applicable).
[ ] This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
[ ] This change has relevant documentation additions / updates (if applicable).
[ ] I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

[ ] VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (develop@861d8aa). Learn more about missing BASE report. Report is 20 commits behind head on develop.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #5796 +/- ## ========================================== Coverage ? 29.55% Complexity ? 4779 ========================================== Files ? 282 Lines ? 20585 Branches ? 0 ========================================== Hits ? 6083 Misses ? 14502 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.