Automattic / vip-go-mu-plugins

The development repo for mu-plugins used on the WordPress VIP Platform.
https://docs.wpvip.com/
GNU General Public License v2.0
192 stars 100 forks source link

fix(two-factor): move `load_plugin_textdomain()` to `init` #5902

Closed sjinks closed 1 month ago

sjinks commented 1 month ago

Description

WordPress Nightly now spits a doing-it-wrong deprecation warning when load_plugin_textdomain() is invoked too early (like in plugins_loaded).

This breaks our tests, such as E2E tests in VIP CLI.

For now, we fix the affected plugins locally and then create a PR to the upstream.

Ref: https://github.com/Automattic/vip-cli/actions/runs/11130390882/job/30929621217?pr=2045

Changelog Description

Fixed

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

Pre-deploy checklist

Steps to Test

Tests must pass.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 30.29%. Comparing base (3a9b969) to head (59f4b8a). Report is 13 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #5902 +/- ## ============================================= + Coverage 30.27% 30.29% +0.01% Complexity 4812 4812 ============================================= Files 287 287 Lines 20711 20699 -12 ============================================= Hits 6271 6271 + Misses 14440 14428 -12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.