search

Automattic / vip-go-wpcom-compat

VIP Go / WordPress.com Compatibility
https://wpvip.com
2 stars 6 forks source link

Proposal: Add support for WPCOM Geo Uniques #28

Closed joshbetz closed 5 years ago

joshbetz commented 5 years ago

VIP Go Geo Uniques is our VIP Go port of the WPCOM Geo Uniques plugin. The function names are changed, but the arguments are the same. This will make it easier to copy VIP themes as-is from WordPress.com.

Keeping differences as minimal as possible while we're keeping the themes in sync across platforms will ease the migration process and then we can update the function names after everything is fully migrated.

Alternatively: We could search replace the function names in the migration process. In my opinion, deprecating the functions in this way is a cleaner approach, but I could see arguments against that as well.

mjangda commented 5 years ago

I think the biggest downside to the deprecation approach is that there's little incentive for most sites to actually go through and update to the newer versions.

If it's easy to search-replace, I'd go with that approach instead.

If we do go with the deprecated functions, we should include the 3rd $replacements param with details on what new function to use instead.

joshbetz commented 5 years ago

After thinking about it some more, I think search-replace is best in this case since it's such a simple/direct conversion from one function name to another. If the arguments were different, we'd likely have to go with the deprecation route.