search

Automattic / vip-go-wpcom-compat

VIP Go / WordPress.com Compatibility
https://wpvip.com
2 stars 6 forks source link

Deprecate wpcom_vip_protected_embed_to_original() #35

Closed brettshumaker closed 5 years ago

brettshumaker commented 5 years ago

This deprecates the wpcom_vip_protected_embed_to_original() function and just returns any $content value it was passed.

joshbetz commented 5 years ago

On WP.com, it looks like that function does the same thing as our Protected Embeds compat shim (render the embed code directly)? Since we're already doing that in this plugin, it should end up working as expected with this function implemented as you have, but maybe worth confirming?

That is, content passed through this function should still have embeds rendered.

brettshumaker commented 5 years ago

it should end up working as expected with this function implemented as you have, but maybe worth confirming?

Absolutely. I believe observer.com was using it with their Facebook Instant Article feeds. I'll sandbox with this patch and make sure the embeds are rendered directly.

brettshumaker commented 5 years ago

Tested running this patch against post content with protected embeds and it does not seem to alter the output.